REF: remove replace_list kludge #33445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Apr 10, 2020
| if isinstance(other, _Timedelta): | ||
| ots = other | ||
| elif PyDelta_Check(other) or isinstance(other, Tick): | ||
| elif (is_timedelta64_object(other) or PyDelta_Check(other) |
There was a problem hiding this comment.
Any performance implications of checking this first now?
There was a problem hiding this comment.
when we have a timedelta64 object we're avoiding a few unnecessary checks below (L784 of which occurs in python-space). otherwise we are delaying everything by the duration of a is_timedelta64_object call, which is small
|
can you rebase so easier to see the diff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sits on top of #33441